Update Delphi.gitignore to remove modules folder #4764
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Boss dependency manager vendor folder from ignore. This is interfering with projects that contains a "modules" folder regardless of Boss dependency being present.
|
Fully Agree. |
|
Bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Boss dependency manager vendor folder from ignore. This is interfering with projects that contains a "modules" folder regardless of Boss dependency being present.
Reasons for making this change
This is a very broad term thats conflicting with projects that contains a modules folder regardless if boss dependency manager is being used. I've already lost source code because of this rule. I do not believe 3rd party tool rules should be applied to official delphi ignore rules by default.
Links to documentation supporting these rule changes
No link.
If this is a new template
Link to application or project’s homepage: none.
Merge and Approval Steps